1.2 KiB
1.2 KiB
/StandardChecks
Use for any feature/change in this repo.
Required Flow
- Confirm low-level proto fields and comments for new/changed behavior.
- Map into typed model structs (async path) with explicit absence handling (
Option) and unknown-enum handling (Unknown(...)/UNKNOWN_LAYER(...)). - Update sync/blocking parity (
KiCadClientBlocking) for any new async methods. - Update CLI surface (
test-scripts/kicad-ipc-cli.rs) so feature is observable from terminal. - Add regression tests:
- decode/mapping test(s)
- CLI arg parse test(s) for new command/flags
- detail/format test(s) if output changed
- Update docs touched by behavior/API (
README.md,docs/TEST_CLI.md, runbooks as needed). - Run checks:
cargo fmt --allcargo testcargo test --features blocking
- Live verify with KiCad open (real socket): run CLI command(s) showing new data path and confirm expected fields.
- Ship:
git status- commit with Conventional Commit
- push branch
- open PR
- request review with
@codex review.
Output Expectations
- Include exact file refs + what changed.
- Include command outputs summary for tests/live run.
- Call out any skipped checks with reason.