jess
/
Graphite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix several cases of errors appearing in the console 

One appeared on load (a deprecated meta tag). One appeared when adding an Identity (Passthrough) node. One appeared when exposing the the Weight parameter of the Stroke node. This also fixes the intended behavior of the bisect script, which was involved when finding the prevenance of these errors.
This commit is contained in:
Keavon Chambers 2026-04-03 03:20:04 -07:00
parent 5edb00bd9a
commit 55115d89d5
4 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
editor/src/messages/portfolio/document/utility_types/network_interface.rs
View File

@ -3994,10 +3994,12 @@ impl NodeNetworkInterface {
self.unload_upstream_node_click_targets(vec![*node_id], network_path); self.unload_upstream_node_click_targets(vec![*node_id], network_path);
self.unload_all_nodes_bounding_box(network_path); self.unload_all_nodes_bounding_box(network_path);
// Unload the interior imports ports // Unload the interior import/export ports if this node has a nested network
let nested_path = [network_path, &[*node_id]].concat(); if matches!(self.implementation(node_id, network_path), Some(DocumentNodeImplementation::Network(_))) {
self.unload_import_export_ports(&nested_path); let nested_path = [network_path, &[*node_id]].concat();
self.unload_modify_import_export(&nested_path); self.unload_import_export_ports(&nested_path);
self.unload_modify_import_export(&nested_path);
}
} }
} else { } else {
self.unload_import_export_ports(network_path); self.unload_import_export_ports(network_path);

5
editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs
View File

@ -242,7 +242,10 @@ impl NodeNetworkInterface {
} }
DocumentNodeImplementation::ProtoNode(proto_node_identifier) => { DocumentNodeImplementation::ProtoNode(proto_node_identifier) => {
let Some(implementations) = NODE_REGISTRY.get(proto_node_identifier) else { let Some(implementations) = NODE_REGISTRY.get(proto_node_identifier) else {
log::error!("Protonode {proto_node_identifier:?} not found in registry in potential_valid_input_types"); // The compiler removes the identity node, so it's expected to be absent from the registry
if proto_node_identifier != &graphene_std::ops::identity::IDENTIFIER {
log::error!("Proto node `{proto_node_identifier:?}` not found in the node registry, in potential_valid_input_types");
}
return Vec::new(); return Vec::new();
}; };
let number_of_inputs = self.number_of_inputs(node_id, network_path); let number_of_inputs = self.number_of_inputs(node_id, network_path);

3
frontend/index.html
View File

@ -16,8 +16,7 @@
<meta name="color-scheme" content="dark only" /> <meta name="color-scheme" content="dark only" />
<meta name="darkreader-lock" /> <meta name="darkreader-lock" />
<meta name="description" content="Graphite is an open source vector graphics editor and procedural design engine. Create and animate with a nondestructive editing workflow that combines layer-based compositing with node-based generative design." /> <meta name="description" content="Graphite is an open source vector graphics editor and procedural design engine. Create and animate with a nondestructive editing workflow that combines layer-based compositing with node-based generative design." />
<meta name="apple-mobile-web-app-capable" content="yes" /> <meta name="mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black-translucent" />
<!-- INDEX_HTML_HEAD_REPLACEMENT --> <!-- INDEX_HTML_HEAD_REPLACEMENT -->
</head> </head>
<body> <body>

3
website/static/js/page/contributor-guide/bisect-tool.js
View File

@ -369,6 +369,7 @@ document.addEventListener("DOMContentLoaded", () => {
// Exists at starting commit, so it was introduced earlier. Search backward (doubling). // Exists at starting commit, so it was introduced earlier. Search backward (doubling).
badIndex = currentIndex; badIndex = currentIndex;
boundarySearching = true; boundarySearching = true;
boundaryOffset = Math.max(1, commits.length - 1 - startIndex);
} else { } else {
// Absent at starting commit, so the issue was introduced more recently. Extend the commit list forward (towards HEAD) before narrowing. // Absent at starting commit, so the issue was introduced more recently. Extend the commit list forward (towards HEAD) before narrowing.
goodIndex = currentIndex; goodIndex = currentIndex;
@ -558,7 +559,7 @@ document.addEventListener("DOMContentLoaded", () => {
stepCount = 0; stepCount = 0;
history = []; history = [];
bisectPhase = "boundary"; bisectPhase = "boundary";
boundaryOffset = 1; boundaryOffset = 0;
boundarySearching = false; boundarySearching = false;
elements.goBackButton?.classList.remove("hidden"); elements.goBackButton?.classList.remove("hidden");
if (elements.testBuildButton instanceof HTMLElement) elements.testBuildButton.style.display = ""; if (elements.testBuildButton instanceof HTMLElement) elements.testBuildButton.style.display = "";