From 55115d89d5f874956d24376c0db0a4c89c4aec3f Mon Sep 17 00:00:00 2001 From: Keavon Chambers Date: Fri, 3 Apr 2026 03:20:04 -0700 Subject: [PATCH] Fix several cases of errors appearing in the console One appeared on load (a deprecated meta tag). One appeared when adding an Identity (Passthrough) node. One appeared when exposing the the Weight parameter of the Stroke node. This also fixes the intended behavior of the bisect script, which was involved when finding the prevenance of these errors. --- .../document/utility_types/network_interface.rs | 10 ++++++---- .../utility_types/network_interface/resolved_types.rs | 5 ++++- frontend/index.html | 3 +-- .../static/js/page/contributor-guide/bisect-tool.js | 3 ++- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/editor/src/messages/portfolio/document/utility_types/network_interface.rs b/editor/src/messages/portfolio/document/utility_types/network_interface.rs index a1fd08e4..026c0351 100644 --- a/editor/src/messages/portfolio/document/utility_types/network_interface.rs +++ b/editor/src/messages/portfolio/document/utility_types/network_interface.rs @@ -3994,10 +3994,12 @@ impl NodeNetworkInterface { self.unload_upstream_node_click_targets(vec![*node_id], network_path); self.unload_all_nodes_bounding_box(network_path); - // Unload the interior imports ports - let nested_path = [network_path, &[*node_id]].concat(); - self.unload_import_export_ports(&nested_path); - self.unload_modify_import_export(&nested_path); + // Unload the interior import/export ports if this node has a nested network + if matches!(self.implementation(node_id, network_path), Some(DocumentNodeImplementation::Network(_))) { + let nested_path = [network_path, &[*node_id]].concat(); + self.unload_import_export_ports(&nested_path); + self.unload_modify_import_export(&nested_path); + } } } else { self.unload_import_export_ports(network_path); diff --git a/editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs b/editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs index 2d285f7e..12e25765 100644 --- a/editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs +++ b/editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs @@ -242,7 +242,10 @@ impl NodeNetworkInterface { } DocumentNodeImplementation::ProtoNode(proto_node_identifier) => { let Some(implementations) = NODE_REGISTRY.get(proto_node_identifier) else { - log::error!("Protonode {proto_node_identifier:?} not found in registry in potential_valid_input_types"); + // The compiler removes the identity node, so it's expected to be absent from the registry + if proto_node_identifier != &graphene_std::ops::identity::IDENTIFIER { + log::error!("Proto node `{proto_node_identifier:?}` not found in the node registry, in potential_valid_input_types"); + } return Vec::new(); }; let number_of_inputs = self.number_of_inputs(node_id, network_path); diff --git a/frontend/index.html b/frontend/index.html index 173f728f..e5447a60 100644 --- a/frontend/index.html +++ b/frontend/index.html @@ -16,8 +16,7 @@ - - + diff --git a/website/static/js/page/contributor-guide/bisect-tool.js b/website/static/js/page/contributor-guide/bisect-tool.js index 76a3c6a5..c1884381 100644 --- a/website/static/js/page/contributor-guide/bisect-tool.js +++ b/website/static/js/page/contributor-guide/bisect-tool.js @@ -369,6 +369,7 @@ document.addEventListener("DOMContentLoaded", () => { // Exists at starting commit, so it was introduced earlier. Search backward (doubling). badIndex = currentIndex; boundarySearching = true; + boundaryOffset = Math.max(1, commits.length - 1 - startIndex); } else { // Absent at starting commit, so the issue was introduced more recently. Extend the commit list forward (towards HEAD) before narrowing. goodIndex = currentIndex; @@ -558,7 +559,7 @@ document.addEventListener("DOMContentLoaded", () => { stepCount = 0; history = []; bisectPhase = "boundary"; - boundaryOffset = 1; + boundaryOffset = 0; boundarySearching = false; elements.goBackButton?.classList.remove("hidden"); if (elements.testBuildButton instanceof HTMLElement) elements.testBuildButton.style.display = "";