From fbd2658148b67642e75aa5072289c1c01e3edacf Mon Sep 17 00:00:00 2001 From: Ayush Amawate <97389618+Ayush2k02@users.noreply.github.com> Date: Sun, 8 Mar 2026 16:10:55 +0530 Subject: [PATCH] Replace deprecated criterion::black_box with std::hint::black_box (#3860) * replace deprecated criterion::black_box with std::hint::black_box * gemini code review suggestions Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * apply formating --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- libraries/math-parser/benches/bench.rs | 7 ++++--- libraries/path-bool/benches/painted_dreams.rs | 4 +++- libraries/path-bool/benches/path_segment_intersection.rs | 4 +++- .../graph-craft/benches/compile_demo_art_criterion.rs | 5 ++++- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/libraries/math-parser/benches/bench.rs b/libraries/math-parser/benches/bench.rs index fd1824c9..68c158b1 100644 --- a/libraries/math-parser/benches/bench.rs +++ b/libraries/math-parser/benches/bench.rs @@ -1,6 +1,7 @@ -use criterion::{Criterion, black_box, criterion_group, criterion_main}; -use math_parser::ast; -use math_parser::context::EvalContext; +use std::hint::black_box; + +use criterion::{Criterion, criterion_group, criterion_main}; +use math_parser::{ast, context::EvalContext}; macro_rules! generate_benchmarks { ($( $input:expr_2021 ),* $(,)?) => { diff --git a/libraries/path-bool/benches/painted_dreams.rs b/libraries/path-bool/benches/painted_dreams.rs index 8eb54402..3513fc6e 100644 --- a/libraries/path-bool/benches/painted_dreams.rs +++ b/libraries/path-bool/benches/painted_dreams.rs @@ -1,4 +1,6 @@ -use criterion::{Criterion, black_box, criterion_group, criterion_main}; +use std::hint::black_box; + +use criterion::{Criterion, criterion_group, criterion_main}; use path_bool::*; pub fn criterion_benchmark(c: &mut Criterion) { diff --git a/libraries/path-bool/benches/path_segment_intersection.rs b/libraries/path-bool/benches/path_segment_intersection.rs index 227fb7ce..25c422bf 100644 --- a/libraries/path-bool/benches/path_segment_intersection.rs +++ b/libraries/path-bool/benches/path_segment_intersection.rs @@ -1,4 +1,6 @@ -use criterion::{Criterion, black_box, criterion_group, criterion_main}; +use std::hint::black_box; + +use criterion::{Criterion, criterion_group, criterion_main}; use glam::DVec2; use path_bool::*; diff --git a/node-graph/graph-craft/benches/compile_demo_art_criterion.rs b/node-graph/graph-craft/benches/compile_demo_art_criterion.rs index c559e738..a614f8db 100644 --- a/node-graph/graph-craft/benches/compile_demo_art_criterion.rs +++ b/node-graph/graph-craft/benches/compile_demo_art_criterion.rs @@ -1,5 +1,8 @@ -use criterion::{Criterion, black_box, criterion_group, criterion_main}; +use std::hint::black_box; + +use criterion::{Criterion, criterion_group, criterion_main}; use graph_craft::util::DEMO_ART; + fn compile_to_proto(c: &mut Criterion) { use graph_craft::util::{compile, load_from_name}; let mut c = c.benchmark_group("Compile Network cold");