From f6ffa45a8180183d70a67d3e41249934a8fcacc9 Mon Sep 17 00:00:00 2001 From: Dennis Kobert Date: Fri, 9 Aug 2024 21:12:31 +0200 Subject: [PATCH] Fix node graph type errors not being shown (#1917) * Fix node graph type errors not being shown * Add newline * Remove unnecessary memo node implementation --------- Co-authored-by: hypercube <0hypercube@gmail.com> --- editor/src/node_graph_executor.rs | 6 ++++++ node-graph/interpreted-executor/src/node_registry.rs | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/editor/src/node_graph_executor.rs b/editor/src/node_graph_executor.rs index dec15d0b..d9357931 100644 --- a/editor/src/node_graph_executor.rs +++ b/editor/src/node_graph_executor.rs @@ -611,6 +611,12 @@ impl NodeGraphExecutor { document.network_interface.document_metadata_mut().update_from_monitor(HashMap::new(), HashMap::new()); log::trace!("{e}"); + responses.add(NodeGraphMessage::UpdateTypes { + resolved_types: Default::default(), + node_graph_errors, + }); + responses.add(NodeGraphMessage::SendGraph); + return Err("Node graph evaluation failed".to_string()); } Ok(result) => result, diff --git a/node-graph/interpreted-executor/src/node_registry.rs b/node-graph/interpreted-executor/src/node_registry.rs index 8989ca72..9f0c9a99 100644 --- a/node-graph/interpreted-executor/src/node_registry.rs +++ b/node-graph/interpreted-executor/src/node_registry.rs @@ -609,7 +609,6 @@ fn node_registry() -> HashMap, input: (), output: QuantizationChannels, params: [QuantizationChannels]), async_node!(graphene_core::memo::MemoNode<_, _>, input: (), output: Vec, params: [Vec]), async_node!(graphene_core::memo::MemoNode<_, _>, input: (), output: Arc, params: [Arc]), - async_node!(graphene_core::memo::MemoNode<_, _>, input: (), output: Arc, params: [Arc]), async_node!(graphene_core::memo::MemoNode<_, _>, input: (), output: WindowHandle, params: [WindowHandle]), #[cfg(feature = "gpu")] async_node!(graphene_core::memo::MemoNode<_, _>, input: (), output: ShaderInputFrame, params: [ShaderInputFrame]),