jess
/
Graphite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect Properties panel widget types for proto nodes (#2323) 

Fix incorrect property types for protonodes
This commit is contained in:
Adam Gerhant 2025-02-27 21:22:02 -08:00 committed by GitHub
parent c3b01605c4
commit cbb535b6b5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
editor/src/messages/portfolio/document/node_graph/node_properties.rs
View File

@ -2121,30 +2121,17 @@ pub(crate) fn generate_node_properties(node_id: NodeId, context: &mut NodeProper
}; };
let mut number_options = (None, None, None); let mut number_options = (None, None, None);
let input_type = match implementation { if let DocumentNodeImplementation::ProtoNode(proto_node_identifier) = implementation {
DocumentNodeImplementation::ProtoNode(proto_node_identifier) => { if let Some(field) = graphene_core::registry::NODE_METADATA
if let Some(field) = graphene_core::registry::NODE_METADATA .lock()
.lock() .unwrap()
.unwrap() .get(&proto_node_identifier.name.clone().into_owned())
.get(&proto_node_identifier.name.clone().into_owned()) .and_then(|metadata| metadata.fields.get(input_index))
.and_then(|metadata| metadata.fields.get(input_index)) {
{ number_options = (field.number_min, field.number_max, field.number_mode_range);
number_options = (field.number_min, field.number_max, field.number_mode_range);
}
let Some(implementations) = &interpreted_executor::node_registry::NODE_REGISTRY.get(proto_node_identifier) else {
log::error!("Could not get implementation for protonode {proto_node_identifier:?}");
return Vec::new();
};
let first_node_io = implementations.keys().next().unwrap_or(const { &graphene_std::NodeIOTypes::empty() });
let Some(input_type) = first_node_io.inputs.get(input_index) else {
log::error!("Could not get input type for protonode {proto_node_identifier:?} at index {input_index:?}");
return Vec::new();
};
input_type.clone()
} }
_ => context.network_interface.input_type(&InputConnector::node(node_id, input_index), context.selection_network_path).0, }
}; let input_type = context.network_interface.input_type(&InputConnector::node(node_id, input_index), context.selection_network_path).0;
property_from_type(node_id, input_index, &input_type, number_options, context) property_from_type(node_id, input_index, &input_type, number_options, context)
}); });
layout.extend(row); layout.extend(row);