From 9ad6c31483185fa45f7ec0b7598cbba42ed69ce3 Mon Sep 17 00:00:00 2001 From: Keavon Chambers Date: Tue, 14 Jan 2025 13:08:47 -0800 Subject: [PATCH] Remove blob URL dead code and clean up more frontend code (#2199) --- .../src/messages/frontend/frontend_message.rs | 17 ---------- .../document/document_message_handler.rs | 2 +- .../portfolio/portfolio_message_handler.rs | 2 +- .../preferences_message_handler.rs | 1 - frontend/src/App.svelte | 2 +- frontend/src/README.md | 10 ++---- frontend/src/components/Editor.svelte | 2 +- .../floating-menus/ColorPicker.svelte | 6 ++-- .../components/floating-menus/MenuList.svelte | 2 +- .../floating-menus/NodeCatalog.svelte | 2 +- .../src/components/panels/Document.svelte | 34 +++++++++---------- frontend/src/components/panels/Layers.svelte | 6 ++-- .../src/components/panels/Properties.svelte | 4 +-- frontend/src/components/views/Graph.svelte | 10 +++--- .../components/widgets/WidgetLayout.svelte | 2 +- .../components/widgets/WidgetSection.svelte | 4 +-- .../src/components/widgets/WidgetSpan.svelte | 6 ++-- .../widgets/buttons/ColorButton.svelte | 4 +-- .../buttons/ParameterExposeButton.svelte | 2 +- .../widgets/buttons/TextButton.svelte | 2 +- .../widgets/inputs/CurveInput.svelte | 2 +- .../widgets/inputs/DropdownInput.svelte | 2 +- .../widgets/inputs/FontInput.svelte | 2 +- .../widgets/inputs/NumberInput.svelte | 2 +- .../widgets/inputs/PivotInput.svelte | 2 +- .../widgets/inputs/RadioInput.svelte | 2 +- .../widgets/inputs/SpectrumInput.svelte | 2 +- .../widgets/inputs/WorkingColorsInput.svelte | 4 +-- .../widgets/labels/Separator.svelte | 2 +- .../widgets/labels/UserInputLabel.svelte | 2 +- .../window/status-bar/StatusBar.svelte | 4 +-- .../window/title-bar/TitleBar.svelte | 4 +-- .../components/window/workspace/Panel.svelte | 4 +-- .../window/workspace/Workspace.svelte | 5 ++- frontend/src/consts.ts | 2 -- .../src/{wasm-communication => }/editor.ts | 9 +++-- frontend/src/io-managers/clipboard.ts | 22 ++---------- frontend/src/io-managers/hyperlinks.ts | 4 +-- frontend/src/io-managers/input.ts | 4 +-- frontend/src/io-managers/localization.ts | 4 +-- frontend/src/io-managers/panic.ts | 4 +-- frontend/src/io-managers/persistence.ts | 4 +-- .../src/{wasm-communication => }/messages.ts | 22 ------------ frontend/src/state-providers/dialog.ts | 4 +-- frontend/src/state-providers/document.ts | 10 ++---- frontend/src/state-providers/fonts.ts | 4 +-- frontend/src/state-providers/fullscreen.ts | 2 +- frontend/src/state-providers/node-graph.ts | 14 ++------ frontend/src/state-providers/portfolio.ts | 27 +++------------ .../subscription-router.ts | 2 +- frontend/src/utility-functions/files.ts | 29 ---------------- .../src/utility-functions/rasterization.ts | 19 +---------- frontend/src/utility-functions/viewports.ts | 2 +- frontend/wasm/src/editor_api.rs | 2 +- .../gcore/src/graphic_element/renderer.rs | 3 -- .../guide/codebase-overview/_index.md | 2 +- 56 files changed, 107 insertions(+), 247 deletions(-) delete mode 100644 frontend/src/consts.ts rename frontend/src/{wasm-communication => }/editor.ts (86%) rename frontend/src/{wasm-communication => }/messages.ts (98%) rename frontend/src/{wasm-communication => }/subscription-router.ts (98%) diff --git a/editor/src/messages/frontend/frontend_message.rs b/editor/src/messages/frontend/frontend_message.rs index 137565ed..1450c4f4 100644 --- a/editor/src/messages/frontend/frontend_message.rs +++ b/editor/src/messages/frontend/frontend_message.rs @@ -58,17 +58,7 @@ pub enum FrontendMessage { #[serde(rename = "commitDate")] commit_date: String, }, - TriggerCopyToClipboardBlobUrl { - #[serde(rename = "blobUrl")] - blob_url: String, - }, TriggerDelayedZoomCanvasToFitAll, - TriggerDownloadBlobUrl { - #[serde(rename = "layerName")] - layer_name: String, - #[serde(rename = "blobUrl")] - blob_url: String, - }, TriggerDownloadImage { svg: String, name: String, @@ -99,9 +89,6 @@ pub enum FrontendMessage { TriggerLoadPreferences, TriggerOpenDocument, TriggerPaste, - TriggerRevokeBlobUrl { - url: String, - }, TriggerSavePreferences { preferences: PreferencesMessageHandler, }, @@ -294,8 +281,4 @@ pub enum FrontendMessage { layout_target: LayoutTarget, diff: Vec, }, - UpdateZoomWithScroll { - #[serde(rename = "zoomWithScroll")] - zoom_with_scroll: bool, - }, } diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs index a1775eaf..0b4c0a6b 100644 --- a/editor/src/messages/portfolio/document/document_message_handler.rs +++ b/editor/src/messages/portfolio/document/document_message_handler.rs @@ -1695,7 +1695,7 @@ impl DocumentMessageHandler { .unwrap_or(0) } - /// Loads layer resources such as creating the blob URLs for the images and loading all of the fonts in the document. + /// Loads all of the fonts in the document. pub fn load_layer_resources(&self, responses: &mut VecDeque) { let mut fonts = HashSet::new(); for (_node_id, node) in self.document_network().recursive_nodes() { diff --git a/editor/src/messages/portfolio/portfolio_message_handler.rs b/editor/src/messages/portfolio/portfolio_message_handler.rs index 9482d2f2..f0f4d251 100644 --- a/editor/src/messages/portfolio/portfolio_message_handler.rs +++ b/editor/src/messages/portfolio/portfolio_message_handler.rs @@ -304,7 +304,7 @@ impl MessageHandler> for PortfolioMes let () = fut.await; use wasm_bindgen::prelude::*; - #[wasm_bindgen(module = "/../frontend/src/wasm-communication/editor.ts")] + #[wasm_bindgen(module = "/../frontend/src/editor.ts")] extern "C" { #[wasm_bindgen(js_name = injectImaginatePollServerStatus)] fn inject(); diff --git a/editor/src/messages/preferences/preferences_message_handler.rs b/editor/src/messages/preferences/preferences_message_handler.rs index 940c8aed..f83234f5 100644 --- a/editor/src/messages/preferences/preferences_message_handler.rs +++ b/editor/src/messages/preferences/preferences_message_handler.rs @@ -96,7 +96,6 @@ impl MessageHandler for PreferencesMessageHandler { true => MappingVariant::ZoomWithScroll, }; responses.add(KeyMappingMessage::ModifyMapping(variant)); - responses.add(FrontendMessage::UpdateZoomWithScroll { zoom_with_scroll }); } } diff --git a/frontend/src/App.svelte b/frontend/src/App.svelte index fd51a513..a43fb1a6 100644 --- a/frontend/src/App.svelte +++ b/frontend/src/App.svelte @@ -1,7 +1,7 @@