From 820865389cd9a6f1e478c1dabe63529c7e591a0f Mon Sep 17 00:00:00 2001 From: Timon Date: Mon, 15 Dec 2025 14:11:43 +0000 Subject: [PATCH] Desktop: UI scale preference (#3475) * ui scale preference * cleanup * add update ui scale message to SIDE_EFFECT_FREE_MESSAGES * fix mac title bar height * hide UI preference section on web * set % as unit of ui scale --- desktop/src/app.rs | 8 +- .../wrapper/src/intercept_frontend_message.rs | 4 + desktop/wrapper/src/messages.rs | 3 + editor/src/consts.rs | 5 + editor/src/dispatcher.rs | 1 + .../preferences_dialog_message_handler.rs | 461 ++++++++++-------- .../src/messages/frontend/frontend_message.rs | 3 + .../preferences/preferences_message.rs | 1 + .../preferences_message_handler.rs | 9 +- .../window/title-bar/TitleBar.svelte | 6 +- frontend/src/messages.ts | 5 + frontend/src/state-providers/app-window.ts | 9 +- 12 files changed, 296 insertions(+), 219 deletions(-) diff --git a/desktop/src/app.rs b/desktop/src/app.rs index fd95ddf5..9aa45fb3 100644 --- a/desktop/src/app.rs +++ b/desktop/src/app.rs @@ -27,6 +27,7 @@ pub(crate) struct App { window_size: PhysicalSize, window_maximized: bool, window_fullscreen: bool, + ui_scale: f64, app_event_receiver: Receiver, app_event_scheduler: AppEventScheduler, desktop_wrapper: DesktopWrapper, @@ -83,6 +84,7 @@ impl App { window_size: PhysicalSize { width: 0, height: 0 }, window_maximized: false, window_fullscreen: false, + ui_scale: 1., app_event_receiver, app_event_scheduler, desktop_wrapper: DesktopWrapper::new(), @@ -119,7 +121,7 @@ impl App { } let size = window.surface_size(); - let scale = window.scale_factor(); + let scale = window.scale_factor() * self.ui_scale; let is_new_size = size != self.window_size; let is_new_scale = scale != self.window_scale; @@ -228,6 +230,10 @@ impl App { render_state.set_viewport_scale([viewport_scale_x as f32, viewport_scale_y as f32]); } } + DesktopFrontendMessage::UpdateUIScale { scale } => { + self.ui_scale = scale; + self.resize(); + } DesktopFrontendMessage::UpdateOverlays(scene) => { if let Some(render_state) = &mut self.render_state { render_state.set_overlays_scene(scene); diff --git a/desktop/wrapper/src/intercept_frontend_message.rs b/desktop/wrapper/src/intercept_frontend_message.rs index bc6398b3..764f11fd 100644 --- a/desktop/wrapper/src/intercept_frontend_message.rs +++ b/desktop/wrapper/src/intercept_frontend_message.rs @@ -67,6 +67,10 @@ pub(super) fn intercept_frontend_message(dispatcher: &mut DesktopWrapperMessageD FrontendMessage::UpdateViewportPhysicalBounds { x, y, width, height } => { dispatcher.respond(DesktopFrontendMessage::UpdateViewportPhysicalBounds { x, y, width, height }); } + FrontendMessage::UpdateUIScale { scale } => { + dispatcher.respond(DesktopFrontendMessage::UpdateUIScale { scale }); + return Some(FrontendMessage::UpdateUIScale { scale }); + } FrontendMessage::TriggerPersistenceWriteDocument { document_id, document, details } => { dispatcher.respond(DesktopFrontendMessage::PersistenceWriteDocument { id: document_id, diff --git a/desktop/wrapper/src/messages.rs b/desktop/wrapper/src/messages.rs index 78a0faca..a5769ecf 100644 --- a/desktop/wrapper/src/messages.rs +++ b/desktop/wrapper/src/messages.rs @@ -35,6 +35,9 @@ pub enum DesktopFrontendMessage { width: f64, height: f64, }, + UpdateUIScale { + scale: f64, + }, UpdateOverlays(vello::Scene), PersistenceWriteDocument { id: DocumentId, diff --git a/editor/src/consts.rs b/editor/src/consts.rs index b17a8621..f515ee07 100644 --- a/editor/src/consts.rs +++ b/editor/src/consts.rs @@ -158,3 +158,8 @@ pub const AUTO_SAVE_TIMEOUT_SECONDS: u64 = 1; // INPUT pub const DOUBLE_CLICK_MILLISECONDS: u64 = 500; + +// UI +pub const UI_SCALE_DEFAULT: f64 = 1.; +pub const UI_SCALE_MIN: f64 = 0.5; +pub const UI_SCALE_MAX: f64 = 3.; diff --git a/editor/src/dispatcher.rs b/editor/src/dispatcher.rs index ae437d11..3e4b575b 100644 --- a/editor/src/dispatcher.rs +++ b/editor/src/dispatcher.rs @@ -52,6 +52,7 @@ const SIDE_EFFECT_FREE_MESSAGES: &[MessageDiscriminant] = &[ ))), MessageDiscriminant::Portfolio(PortfolioMessageDiscriminant::SubmitActiveGraphRender), MessageDiscriminant::Frontend(FrontendMessageDiscriminant::TriggerFontLoad), + MessageDiscriminant::Frontend(FrontendMessageDiscriminant::UpdateUIScale), ]; /// Since we don't need to update the frontend multiple times per frame, /// we have a set of messages which we will buffer until the next frame is requested. diff --git a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs b/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs index 74034200..0c25cf46 100644 --- a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs +++ b/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs @@ -1,4 +1,4 @@ -use crate::consts::{VIEWPORT_ZOOM_WHEEL_RATE, VIEWPORT_ZOOM_WHEEL_RATE_CHANGE}; +use crate::consts::{UI_SCALE_DEFAULT, UI_SCALE_MAX, UI_SCALE_MIN, VIEWPORT_ZOOM_WHEEL_RATE, VIEWPORT_ZOOM_WHEEL_RATE_CHANGE}; use crate::messages::layout::utility_types::widget_prelude::*; use crate::messages::portfolio::document::utility_types::wires::GraphWireStyle; use crate::messages::preferences::SelectionMode; @@ -36,250 +36,273 @@ impl PreferencesDialogMessageHandler { const TITLE: &'static str = "Editor Preferences"; fn layout(&self, preferences: &PreferencesMessageHandler) -> Layout { + let mut rows = Vec::new(); + // ========== // NAVIGATION // ========== + { + let header = vec![TextLabel::new("Navigation").italic(true).widget_instance()]; - let navigation_header = vec![TextLabel::new("Navigation").italic(true).widget_instance()]; + let zoom_rate_description = "Adjust how fast zooming occurs when using the scroll wheel or pinch gesture (relative to a default of 50)."; + let zoom_rate_label = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + TextLabel::new("Zoom Rate").tooltip_label("Zoom Rate").tooltip_description(zoom_rate_description).widget_instance(), + ]; + let zoom_rate = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + NumberInput::new(Some(map_zoom_rate_to_display(preferences.viewport_zoom_wheel_rate))) + .tooltip_label("Zoom Rate") + .tooltip_description(zoom_rate_description) + .mode_range() + .int() + .min(1.) + .max(100.) + .on_update(|number_input: &NumberInput| { + if let Some(display_value) = number_input.value { + let actual_rate = map_display_to_zoom_rate(display_value); + PreferencesMessage::ViewportZoomWheelRate { rate: actual_rate }.into() + } else { + PreferencesMessage::ViewportZoomWheelRate { rate: VIEWPORT_ZOOM_WHEEL_RATE }.into() + } + }) + .widget_instance(), + ]; - let zoom_rate_description = "Adjust how fast zooming occurs when using the scroll wheel or pinch gesture (relative to a default of 50)."; - let zoom_rate_label = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - TextLabel::new("Zoom Rate").tooltip_label("Zoom Rate").tooltip_description(zoom_rate_description).widget_instance(), - ]; - let zoom_rate = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - NumberInput::new(Some(map_zoom_rate_to_display(preferences.viewport_zoom_wheel_rate))) - .tooltip_label("Zoom Rate") - .tooltip_description(zoom_rate_description) - .mode_range() - .int() - .min(1.) - .max(100.) - .on_update(|number_input: &NumberInput| { - if let Some(display_value) = number_input.value { - let actual_rate = map_display_to_zoom_rate(display_value); - PreferencesMessage::ViewportZoomWheelRate { rate: actual_rate }.into() - } else { - PreferencesMessage::ViewportZoomWheelRate { rate: VIEWPORT_ZOOM_WHEEL_RATE }.into() - } - }) - .widget_instance(), - ]; + let checkbox_id = CheckboxId::new(); + let zoom_with_scroll_description = "Use the scroll wheel for zooming instead of vertically panning (not recommended for trackpads)."; + let zoom_with_scroll = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + CheckboxInput::new(preferences.zoom_with_scroll) + .tooltip_label("Zoom with Scroll") + .tooltip_description(zoom_with_scroll_description) + .on_update(|checkbox_input: &CheckboxInput| { + PreferencesMessage::ModifyLayout { + zoom_with_scroll: checkbox_input.checked, + } + .into() + }) + .for_label(checkbox_id) + .widget_instance(), + TextLabel::new("Zoom with Scroll") + .tooltip_label("Zoom with Scroll") + .tooltip_description(zoom_with_scroll_description) + .for_checkbox(checkbox_id) + .widget_instance(), + ]; - let checkbox_id = CheckboxId::new(); - let zoom_with_scroll_description = "Use the scroll wheel for zooming instead of vertically panning (not recommended for trackpads)."; - let zoom_with_scroll = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - CheckboxInput::new(preferences.zoom_with_scroll) - .tooltip_label("Zoom with Scroll") - .tooltip_description(zoom_with_scroll_description) - .on_update(|checkbox_input: &CheckboxInput| { - PreferencesMessage::ModifyLayout { - zoom_with_scroll: checkbox_input.checked, - } - .into() - }) - .for_label(checkbox_id) - .widget_instance(), - TextLabel::new("Zoom with Scroll") - .tooltip_label("Zoom with Scroll") - .tooltip_description(zoom_with_scroll_description) - .for_checkbox(checkbox_id) - .widget_instance(), - ]; + rows.extend_from_slice(&[header, zoom_rate_label, zoom_rate, zoom_with_scroll]); + } // ======= // EDITING // ======= + { + let header = vec![TextLabel::new("Editing").italic(true).widget_instance()]; - let editing_header = vec![TextLabel::new("Editing").italic(true).widget_instance()]; + let selection_label = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + TextLabel::new("Selection") + .tooltip_label("Selection") + .tooltip_description("Choose how targets are selected within dragged rectangular and lasso areas.") + .widget_instance(), + ]; - let selection_label = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - TextLabel::new("Selection") - .tooltip_label("Selection") - .tooltip_description("Choose how targets are selected within dragged rectangular and lasso areas.") - .widget_instance(), - ]; + let selection_mode = RadioInput::new(vec![ + RadioEntryData::new(SelectionMode::Touched.to_string()) + .label(SelectionMode::Touched.to_string()) + .tooltip_label(SelectionMode::Touched.to_string()) + .tooltip_description(SelectionMode::Touched.tooltip_description()) + .on_update(move |_| { + PreferencesMessage::SelectionMode { + selection_mode: SelectionMode::Touched, + } + .into() + }), + RadioEntryData::new(SelectionMode::Enclosed.to_string()) + .label(SelectionMode::Enclosed.to_string()) + .tooltip_label(SelectionMode::Enclosed.to_string()) + .tooltip_description(SelectionMode::Enclosed.tooltip_description()) + .on_update(move |_| { + PreferencesMessage::SelectionMode { + selection_mode: SelectionMode::Enclosed, + } + .into() + }), + RadioEntryData::new(SelectionMode::Directional.to_string()) + .label(SelectionMode::Directional.to_string()) + .tooltip_label(SelectionMode::Directional.to_string()) + .tooltip_description(SelectionMode::Directional.tooltip_description()) + .on_update(move |_| { + PreferencesMessage::SelectionMode { + selection_mode: SelectionMode::Directional, + } + .into() + }), + ]) + .selected_index(Some(preferences.selection_mode as u32)) + .widget_instance(); + let selection_mode = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + selection_mode, + ]; - let selection_mode = RadioInput::new(vec![ - RadioEntryData::new(SelectionMode::Touched.to_string()) - .label(SelectionMode::Touched.to_string()) - .tooltip_label(SelectionMode::Touched.to_string()) - .tooltip_description(SelectionMode::Touched.tooltip_description()) - .on_update(move |_| { - PreferencesMessage::SelectionMode { - selection_mode: SelectionMode::Touched, - } - .into() - }), - RadioEntryData::new(SelectionMode::Enclosed.to_string()) - .label(SelectionMode::Enclosed.to_string()) - .tooltip_label(SelectionMode::Enclosed.to_string()) - .tooltip_description(SelectionMode::Enclosed.tooltip_description()) - .on_update(move |_| { - PreferencesMessage::SelectionMode { - selection_mode: SelectionMode::Enclosed, - } - .into() - }), - RadioEntryData::new(SelectionMode::Directional.to_string()) - .label(SelectionMode::Directional.to_string()) - .tooltip_label(SelectionMode::Directional.to_string()) - .tooltip_description(SelectionMode::Directional.tooltip_description()) - .on_update(move |_| { - PreferencesMessage::SelectionMode { - selection_mode: SelectionMode::Directional, - } - .into() - }), - ]) - .selected_index(Some(preferences.selection_mode as u32)) - .widget_instance(); - let selection_mode = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - selection_mode, - ]; + rows.extend_from_slice(&[header, selection_label, selection_mode]); + } + + // ========== + // UI + // ========== + #[cfg(not(target_family = "wasm"))] + { + let header = vec![TextLabel::new("UI").italic(true).widget_instance()]; + + let scale_description = "Adjust the scale of the user interface (100 is default)."; + let scale_label = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + TextLabel::new("Scale").tooltip_label("Scale").tooltip_description(scale_description).widget_instance(), + ]; + let scale = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + NumberInput::new(Some(ui_scale_to_display(preferences.ui_scale))) + .tooltip_label("Scale") + .tooltip_description(scale_description) + .mode_range() + .int() + .min(ui_scale_to_display(UI_SCALE_MIN)) + .max(ui_scale_to_display(UI_SCALE_MAX)) + .unit("%") + .on_update(|number_input: &NumberInput| { + if let Some(display_value) = number_input.value { + let scale = map_display_to_ui_scale(display_value); + PreferencesMessage::UIScale { scale }.into() + } else { + PreferencesMessage::UIScale { scale: UI_SCALE_DEFAULT }.into() + } + }) + .widget_instance(), + ]; + + rows.extend_from_slice(&[header, scale_label, scale]); + } // ============ // EXPERIMENTAL // ============ + { + let header = vec![TextLabel::new("Experimental").italic(true).widget_instance()]; - let experimental_header = vec![TextLabel::new("Experimental").italic(true).widget_instance()]; + let node_graph_section_description = "Configure the appearance of the wires running between node connections in the graph."; + let node_graph_wires_label = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + TextLabel::new("Node Graph Wires") + .tooltip_label("Node Graph Wires") + .tooltip_description(node_graph_section_description) + .widget_instance(), + ]; + let graph_wire_style = RadioInput::new(vec![ + RadioEntryData::new(GraphWireStyle::Direct.to_string()) + .label(GraphWireStyle::Direct.to_string()) + .tooltip_label(GraphWireStyle::Direct.to_string()) + .tooltip_description(GraphWireStyle::Direct.tooltip_description()) + .on_update(move |_| PreferencesMessage::GraphWireStyle { style: GraphWireStyle::Direct }.into()), + RadioEntryData::new(GraphWireStyle::GridAligned.to_string()) + .label(GraphWireStyle::GridAligned.to_string()) + .tooltip_label(GraphWireStyle::GridAligned.to_string()) + .tooltip_description(GraphWireStyle::GridAligned.tooltip_description()) + .on_update(move |_| PreferencesMessage::GraphWireStyle { style: GraphWireStyle::GridAligned }.into()), + ]) + .selected_index(Some(preferences.graph_wire_style as u32)) + .widget_instance(); + let graph_wire_style = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + graph_wire_style, + ]; - let node_graph_section_description = "Configure the appearance of the wires running between node connections in the graph."; - let node_graph_wires_label = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - TextLabel::new("Node Graph Wires") - .tooltip_label("Node Graph Wires") - .tooltip_description(node_graph_section_description) - .widget_instance(), - ]; - let graph_wire_style = RadioInput::new(vec![ - RadioEntryData::new(GraphWireStyle::Direct.to_string()) - .label(GraphWireStyle::Direct.to_string()) - .tooltip_label(GraphWireStyle::Direct.to_string()) - .tooltip_description(GraphWireStyle::Direct.tooltip_description()) - .on_update(move |_| PreferencesMessage::GraphWireStyle { style: GraphWireStyle::Direct }.into()), - RadioEntryData::new(GraphWireStyle::GridAligned.to_string()) - .label(GraphWireStyle::GridAligned.to_string()) - .tooltip_label(GraphWireStyle::GridAligned.to_string()) - .tooltip_description(GraphWireStyle::GridAligned.tooltip_description()) - .on_update(move |_| PreferencesMessage::GraphWireStyle { style: GraphWireStyle::GridAligned }.into()), - ]) - .selected_index(Some(preferences.graph_wire_style as u32)) - .widget_instance(); - let graph_wire_style = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - graph_wire_style, - ]; + let checkbox_id = CheckboxId::new(); + let vello_description = "Use the experimental Vello renderer instead of SVG-based rendering.".to_string(); + #[cfg(target_family = "wasm")] + let mut vello_description = vello_description; + #[cfg(target_family = "wasm")] + vello_description.push_str("\n\n(Your browser must support WebGPU.)"); - let checkbox_id = CheckboxId::new(); - let vello_description = "Use the experimental Vello renderer instead of SVG-based rendering.".to_string(); - #[cfg(target_family = "wasm")] - let mut vello_description = vello_description; - #[cfg(target_family = "wasm")] - vello_description.push_str("\n\n(Your browser must support WebGPU.)"); + let use_vello = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + CheckboxInput::new(preferences.use_vello && preferences.supports_wgpu()) + .tooltip_label("Vello Renderer") + .tooltip_description(vello_description.clone()) + .disabled(!preferences.supports_wgpu()) + .on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::UseVello { use_vello: checkbox_input.checked }.into()) + .for_label(checkbox_id) + .widget_instance(), + TextLabel::new("Vello Renderer") + .tooltip_label("Vello Renderer") + .tooltip_description(vello_description) + .disabled(!preferences.supports_wgpu()) + .for_checkbox(checkbox_id) + .widget_instance(), + ]; - let use_vello = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - CheckboxInput::new(preferences.use_vello && preferences.supports_wgpu()) - .tooltip_label("Vello Renderer") - .tooltip_description(vello_description.clone()) - .disabled(!preferences.supports_wgpu()) - .on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::UseVello { use_vello: checkbox_input.checked }.into()) - .for_label(checkbox_id) - .widget_instance(), - TextLabel::new("Vello Renderer") - .tooltip_label("Vello Renderer") - .tooltip_description(vello_description) - .disabled(!preferences.supports_wgpu()) - .for_checkbox(checkbox_id) - .widget_instance(), - ]; - - let checkbox_id = CheckboxId::new(); - let vector_mesh_description = " + let checkbox_id = CheckboxId::new(); + let vector_mesh_description = " Allow the Pen tool to produce branching geometry, where more than two segments may be connected to one anchor point.\n\ \n\ Currently, vector meshes do not properly render strokes (branching joins) and fills (multiple regions). " - .trim(); - let vector_meshes = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - CheckboxInput::new(preferences.vector_meshes) - .tooltip_label("Vector Meshes") - .tooltip_description(vector_mesh_description) - .on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::VectorMeshes { enabled: checkbox_input.checked }.into()) - .for_label(checkbox_id) - .widget_instance(), - TextLabel::new("Vector Meshes") - .tooltip_label("Vector Meshes") - .tooltip_description(vector_mesh_description) - .for_checkbox(checkbox_id) - .widget_instance(), - ]; + .trim(); + let vector_meshes = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + CheckboxInput::new(preferences.vector_meshes) + .tooltip_label("Vector Meshes") + .tooltip_description(vector_mesh_description) + .on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::VectorMeshes { enabled: checkbox_input.checked }.into()) + .for_label(checkbox_id) + .widget_instance(), + TextLabel::new("Vector Meshes") + .tooltip_label("Vector Meshes") + .tooltip_description(vector_mesh_description) + .for_checkbox(checkbox_id) + .widget_instance(), + ]; - let checkbox_id = CheckboxId::new(); - let brush_tool_description = " + let checkbox_id = CheckboxId::new(); + let brush_tool_description = " Enable the Brush tool to support basic raster-based layer painting.\n\ \n\ This legacy tool has performance and quality limitations and is slated for replacement in future versions of Graphite that will focus on raster graphics editing. " - .trim(); - let brush_tool = vec![ - Separator::new(SeparatorType::Unrelated).widget_instance(), - Separator::new(SeparatorType::Unrelated).widget_instance(), - CheckboxInput::new(preferences.brush_tool) - .tooltip_label("Brush Tool") - .tooltip_description(brush_tool_description) - .on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::BrushTool { enabled: checkbox_input.checked }.into()) - .for_label(checkbox_id) - .widget_instance(), - TextLabel::new("Brush Tool") - .tooltip_label("Brush Tool") - .tooltip_description(brush_tool_description) - .for_checkbox(checkbox_id) - .widget_instance(), - ]; + .trim(); + let brush_tool = vec![ + Separator::new(SeparatorType::Unrelated).widget_instance(), + Separator::new(SeparatorType::Unrelated).widget_instance(), + CheckboxInput::new(preferences.brush_tool) + .tooltip_label("Brush Tool") + .tooltip_description(brush_tool_description) + .on_update(|checkbox_input: &CheckboxInput| PreferencesMessage::BrushTool { enabled: checkbox_input.checked }.into()) + .for_label(checkbox_id) + .widget_instance(), + TextLabel::new("Brush Tool") + .tooltip_label("Brush Tool") + .tooltip_description(brush_tool_description) + .for_checkbox(checkbox_id) + .widget_instance(), + ]; - Layout(vec![ - // NAVIGATION - LayoutGroup::Row { widgets: navigation_header }, - // Navigation: Zoom Rate - LayoutGroup::Row { widgets: zoom_rate_label }, - LayoutGroup::Row { widgets: zoom_rate }, - // Navigation: Zoom with Scroll - LayoutGroup::Row { widgets: zoom_with_scroll }, - // - // EDITING - LayoutGroup::Row { widgets: editing_header }, - // Editing: Selection - LayoutGroup::Row { widgets: selection_label }, - LayoutGroup::Row { widgets: selection_mode }, - // - // EXPERIMENTAL - LayoutGroup::Row { widgets: experimental_header }, - // Experimental: Node Graph Wires - LayoutGroup::Row { widgets: node_graph_wires_label }, - LayoutGroup::Row { widgets: graph_wire_style }, - // Experimental: Vello Renderer - LayoutGroup::Row { widgets: use_vello }, - // Experimental: Vector Meshes - LayoutGroup::Row { widgets: vector_meshes }, - // Experimental: Brush Tool - LayoutGroup::Row { widgets: brush_tool }, - ]) + rows.extend_from_slice(&[header, node_graph_wires_label, graph_wire_style, use_vello, vector_meshes, brush_tool]); + } + + Layout(rows.into_iter().map(|r| LayoutGroup::Row { widgets: r }).collect()) } pub fn send_layout(&self, responses: &mut VecDeque, layout_target: LayoutTarget, preferences: &PreferencesMessageHandler) { @@ -351,3 +374,13 @@ fn map_zoom_rate_to_display(rate: f64) -> f64 { let display = 50. + distance_from_reference; display.clamp(1., 100.).round() } + +/// Maps display values in percent to actual ui scale. +fn map_display_to_ui_scale(display: f64) -> f64 { + display / 100. +} + +/// Maps actual ui scale back to display values in percent. +fn ui_scale_to_display(scale: f64) -> f64 { + scale * 100. +} diff --git a/editor/src/messages/frontend/frontend_message.rs b/editor/src/messages/frontend/frontend_message.rs index 573dc8ff..202d7e23 100644 --- a/editor/src/messages/frontend/frontend_message.rs +++ b/editor/src/messages/frontend/frontend_message.rs @@ -338,6 +338,9 @@ pub enum FrontendMessage { width: f64, height: f64, }, + UpdateUIScale { + scale: f64, + }, #[cfg(not(target_family = "wasm"))] RenderOverlays { diff --git a/editor/src/messages/preferences/preferences_message.rs b/editor/src/messages/preferences/preferences_message.rs index 0b58e8c1..027bdd40 100644 --- a/editor/src/messages/preferences/preferences_message.rs +++ b/editor/src/messages/preferences/preferences_message.rs @@ -17,4 +17,5 @@ pub enum PreferencesMessage { ModifyLayout { zoom_with_scroll: bool }, GraphWireStyle { style: GraphWireStyle }, ViewportZoomWheelRate { rate: f64 }, + UIScale { scale: f64 }, } diff --git a/editor/src/messages/preferences/preferences_message_handler.rs b/editor/src/messages/preferences/preferences_message_handler.rs index 06080b23..2cc0b5ae 100644 --- a/editor/src/messages/preferences/preferences_message_handler.rs +++ b/editor/src/messages/preferences/preferences_message_handler.rs @@ -1,4 +1,4 @@ -use crate::consts::VIEWPORT_ZOOM_WHEEL_RATE; +use crate::consts::{UI_SCALE_DEFAULT, VIEWPORT_ZOOM_WHEEL_RATE}; use crate::messages::input_mapper::key_mapping::MappingVariant; use crate::messages::portfolio::document::utility_types::wires::GraphWireStyle; use crate::messages::preferences::SelectionMode; @@ -14,6 +14,7 @@ pub struct PreferencesMessageHandler { pub brush_tool: bool, pub graph_wire_style: GraphWireStyle, pub viewport_zoom_wheel_rate: f64, + pub ui_scale: f64, } impl PreferencesMessageHandler { @@ -42,6 +43,7 @@ impl Default for PreferencesMessageHandler { brush_tool: false, graph_wire_style: GraphWireStyle::default(), viewport_zoom_wheel_rate: VIEWPORT_ZOOM_WHEEL_RATE, + ui_scale: UI_SCALE_DEFAULT, } } } @@ -61,6 +63,7 @@ impl MessageHandler for PreferencesMessageHandler { responses.add(PreferencesMessage::ModifyLayout { zoom_with_scroll: self.zoom_with_scroll, }); + responses.add(FrontendMessage::UpdateUIScale { scale: self.ui_scale }); } PreferencesMessage::ResetToDefaults => { refresh_dialog(responses); @@ -99,6 +102,10 @@ impl MessageHandler for PreferencesMessageHandler { PreferencesMessage::ViewportZoomWheelRate { rate } => { self.viewport_zoom_wheel_rate = rate; } + PreferencesMessage::UIScale { scale } => { + self.ui_scale = scale; + responses.add(FrontendMessage::UpdateUIScale { scale: self.ui_scale }); + } } responses.add(FrontendMessage::TriggerSavePreferences { preferences: self.clone() }); diff --git a/frontend/src/components/window/title-bar/TitleBar.svelte b/frontend/src/components/window/title-bar/TitleBar.svelte index 71b04682..802066a9 100644 --- a/frontend/src/components/window/title-bar/TitleBar.svelte +++ b/frontend/src/components/window/title-bar/TitleBar.svelte @@ -17,6 +17,9 @@ let menuBarLayout: Layout = []; + // On mac menu bar needs to be scaled with inverse of UI scale to match native menu buttons. + $: height = $appWindow.platform === "Mac" ? 28 * (1 / $appWindow.uiScale) : 28; + onMount(() => { editor.subscriptions.subscribeJsMessage(UpdateMenuBarLayout, (updateMenuBarLayout) => { patchLayout(menuBarLayout, updateMenuBarLayout); @@ -25,7 +28,7 @@ }); - + {#if $appWindow.platform !== "Mac"} @@ -48,7 +51,6 @@