jess
/
Graphite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make Vello render groups with a blending stack only when necessary (#1905) 

Only use group blends when necessary
This commit is contained in:
Dennis Kobert 2024-08-06 07:31:13 +02:00 committed by GitHub
parent ed841803ce
commit 5474a22b2e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
node-graph/gcore/src/graphic_element/renderer.rs
View File

@ -328,16 +328,23 @@ impl GraphicElementRendered for GraphicGroup {
let Some(bounds) = self.bounding_box(transform) else { return }; let Some(bounds) = self.bounding_box(transform) else { return };
let blending = vello::peniko::BlendMode::new(self.alpha_blending.blend_mode.into(), vello::peniko::Compose::SrcOver); let blending = vello::peniko::BlendMode::new(self.alpha_blending.blend_mode.into(), vello::peniko::Compose::SrcOver);
scene.push_layer( let mut layer = false;
blending,
self.alpha_blending.opacity, if self.alpha_blending.opacity < 1. || self.alpha_blending.blend_mode != BlendMode::default() {
kurbo::Affine::IDENTITY, layer = true;
&vello::kurbo::Rect::new(bounds[0].x, bounds[0].y, bounds[1].x, bounds[1].y), scene.push_layer(
); blending,
self.alpha_blending.opacity,
kurbo::Affine::IDENTITY,
&vello::kurbo::Rect::new(bounds[0].x, bounds[0].y, bounds[1].x, bounds[1].y),
);
}
for element in self.iter() { for element in self.iter() {
element.render_to_vello(scene, child_transform); element.render_to_vello(scene, child_transform);
} }
scene.pop_layer(); if layer {
scene.pop_layer();
}
} }
fn contains_artboard(&self) -> bool { fn contains_artboard(&self) -> bool {