jess
/
Graphite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Path tool path drag ghost outline sticking to viewport, not moving with document while dragging (#2912) 

* Added ghost outline clearing when moving outlines via Path Tool

* Fix ghost outline staying fixed during drag by storing it in document space

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Szilveszter Ábrám 2025-07-24 11:28:17 +02:00 committed by GitHub
parent 30abc92900
commit 0d43ad2ea0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
editor/src/messages/tool/tool_messages/path_tool.rs
View File

@ -532,7 +532,7 @@ struct PathToolData {
drill_through_cycle_index: usize, drill_through_cycle_index: usize,
drill_through_cycle_count: usize, drill_through_cycle_count: usize,
hovered_layers: Vec<LayerNodeIdentifier>, hovered_layers: Vec<LayerNodeIdentifier>,
ghost_outline: Vec<(Vec<ClickTargetType>, DAffine2)>, ghost_outline: Vec<(Vec<ClickTargetType>, LayerNodeIdentifier)>,
single_path_node_compatible_layer_selected: bool, single_path_node_compatible_layer_selected: bool,
} }
@ -628,8 +628,8 @@ impl PathToolData {
for &layer in shape_editor.selected_shape_state.keys() { for &layer in shape_editor.selected_shape_state.keys() {
// We probably need to collect here // We probably need to collect here
let outline: Vec<ClickTargetType> = document.metadata().layer_with_free_points_outline(layer).cloned().collect(); let outline: Vec<ClickTargetType> = document.metadata().layer_with_free_points_outline(layer).cloned().collect();
let transform = document.metadata().transform_to_viewport(layer);
self.ghost_outline.push((outline, transform)); self.ghost_outline.push((outline, layer));
} }
} }
@ -1490,8 +1490,9 @@ impl Fsm for PathToolFsmState {
} }
(_, PathToolMessage::Overlays(mut overlay_context)) => { (_, PathToolMessage::Overlays(mut overlay_context)) => {
if matches!(self, Self::Dragging(_)) { if matches!(self, Self::Dragging(_)) {
for (outline, transform) in &tool_data.ghost_outline { for (outline, layer) in &tool_data.ghost_outline {
overlay_context.outline(outline.iter(), *transform, Some(COLOR_OVERLAY_GRAY)); let transform = document.metadata().transform_to_viewport(*layer);
overlay_context.outline(outline.iter(), transform, Some(COLOR_OVERLAY_GRAY));
} }
} }